Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Multiple Language Server CompletionOptions Support #1948

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Updates for Multiple Language Server CompletionOptions Support #1948

merged 3 commits into from
Jul 14, 2020

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented May 29, 2020 •
edited
Loading

Unblocked with the latest LSP Platform Insertion. This is now ready to merge.

Fixes: https://github.com/dotnet/aspnetcore/issues/21346

@TanayParikh TanayParikh added the blocked Blocked on a partner team label Jun 16, 2020
@TanayParikh TanayParikh marked this pull request as ready for review July 14, 2020 00:42
@TanayParikh TanayParikh removed the blocked Blocked on a partner team label Jul 14, 2020
@TanayParikh
Copy link
Contributor Author

What does "processed" mean here?

O# (prior to 0.16) does not utilize the AllCommitCharacters property (the property is simply dropped).

Aka, given in this PR that we're removing : from the "AllCommitCharacters" in the InitializeHandler Does O# not processing this successfully mean you can't complete completions with : now?

We still provide : as a commit characters for appropriate completion items (ex. @onkeypress) which completes using the : char. The AllCommitCharacters not being "processed" isn't really a big deal as it's a backup anyways for when commit chars of individual completions aren't available. We had added the : to the AllCommitCharacters as a placeholder, due to the LSP platform bug which caused the LSP platform to not reflect that part of the LSP spec.

@TanayParikh TanayParikh merged commit 06848c4 into master Jul 14, 2020
@TanayParikh TanayParikh deleted the taparik/CompletionOptionsCommit-21346 branch July 14, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTaylorMullen NTaylorMullen NTaylorMullen approved these changes

@ajaybhargavb ajaybhargavb ajaybhargavb approved these changes

@noahbkim noahbkim Awaiting requested review from noahbkim

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompletionOptions from Multiple Language Servers Aren't Respected
3 participants
@TanayParikh @ajaybhargavb @NTaylorMullen